Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.vala #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

commonsourcecs
Copy link

Implement "Exit if Root".

This would close issue #3

Note: This PR makes no extra steps to address other contingencies for root as seen in lines 409, 763, etc.

Implement "Exit if Root".
@guinux
Copy link
Collaborator

guinux commented Nov 16, 2024

I can't merge this because pamac is totally usable as root if AUR is disabled. I even added some code be able to build packages when used as root.

@commonsourcecs
Copy link
Author

Then another approach or fix is needed, as users who do run pamac with sudo or as root recurrently break permissions.
It also seems to cause failures in certain circumstances.

See examples here (there are many more);
-Failure:
https://forum.manjaro.org/t/pamac-command-line-failed-to-synchronize-aur-database/170600
-Broken Permissions:
https://forum.manjaro.org/t/new-user-created-missing-permissions/169894

Would a preference be for

  • 'Exit if Root' only for AUR transactions
  • Some other 'fixing' of the behavior under root/sudo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants